search

coreos / butane

Butane translates human-readable Butane Configs into machine-readable Ignition Configs.
https://coreos.github.io/butane/
Apache License 2.0
255 stars 70 forks source link

Stabilize fcos 1.5.0 #434

Closed prestist closed 1 year ago

prestist commented 1 year ago

Pending https://github.com/coreos/butane/pull/289

Following the steps found in https://coreos.github.io/butane/development/ re stabilization.

bgilbert commented 1 year ago

@tormath1 @7flying It'd make sense for us to stabilize flatcar 1.1.0 and r4e 1.1.0 also, so users of those distros can use the new features in the Ignition 3.4.0 spec. Does that work for you? Otherwise we'll bump flatcar 1.1.0-experimental and/or r4e 1.1.0-experimental to the Ignition 3.5.0-experimental spec.

tormath1 commented 1 year ago

Hello @bgilbert, that makes sense yes, on the Flatcar side, we updated Ignition to 2.15.0 on the latest Alpha. If I understand correctly, we would have: butane 1.0.0 -> ignition 3.3.0 butane 1.1.0 -> ignition 3.4.0 and a new butane 1.2.0-experimental -> ignition 3.5.0-experimental ?

travier commented 1 year ago

yes, that's the idea

travier commented 1 year ago

https://coreos.github.io/butane/specs/#butane-specifications-and-ignition-specifications

tormath1 commented 1 year ago

Ok perfect - let me know if you want us to send a PR for Flatcar :)

travier commented 1 year ago

I think we'll do it together in a single PR for all specs

travier commented 1 year ago

CC @runcom for R4E

7flying commented 1 year ago

So in edge we have all the docs already asking the users to use the rfe variant at version 1.0.0 which targets Ignition 3.3.0. We can stabilise 1.1.0 since the subset of options that we support is the same one as 1.0.0 has, unless there are some other implications that I'm not aware of.

travier commented 1 year ago

RHEL 9.2 will have Ignition 2.15 that will be able to use the 3.4.0 Ignition spec. Not sure how much of an improvement that is for R4E.

7flying commented 1 year ago

RHEL 9.2 will have Ignition 2.15 that will be able to use the 3.4.0 Ignition spec. Not sure how much of an improvement that is for R4E.

Is that Ignition 2.15 still able to handle Ignition spec 3.3.0 if we say r4e v1.0.0? If not I will have to notify the docs team

bgilbert commented 1 year ago

Yes. Stabilizing a new spec does not affect existing specs.

bgilbert commented 1 year ago

Thanks for the feedback @tormath1 and @7flying! We'll plan to stabilize both the flatcar and r4e specs.

bgilbert commented 1 year ago

This can happen after #441 lands.