search

coreos / butane

Butane translates human-readable Butane Configs into machine-readable Ignition Configs.
https://coreos.github.io/butane/
Apache License 2.0
255 stars 70 forks source link

Stabilize openshift 4.14.0; create openshift 4.15.0-experimental #491

Closed travier closed 1 year ago

travier commented 1 year ago

See checklist in https://github.com/coreos/butane/issues/488.

openshift/v4_15_exp: Copy from 4.14_exp

openshift/v4_15_exp: Update spec to 4.15.0-experimental

openshift/v4.14: Stabilize 4.14.0 spec

openshift/v4.14: Use fcos 1.5 & ignition 3.4 specs

Stabilise openshift 4.14.0 spec on fcos 1.5 and ignition 3.4 stable specs. The MCO is now capable of understanding Ignition 3.4.0 specs and uses that by default.

See: https://github.com/openshift/machine-config-operator/pull/3576 See: https://github.com/openshift/machine-config-operator/pull/3814

openshift/v4.14: Remove GRUB password support

Remove all GRUB bootloader configuration sugar for openshift/v4.14 configs as the MCO does not know how to manage files in the read only /boot partition yet. While we could use Ignition to write the initial file, any update would fail which makes for a bad user experience.

This is revert of [1] for openshift/v4.14 only.

[1] https://github.com/coreos/butane/commit/4bd006e3f00eae89f9555e986b331fce8fdc2882 See: https://issues.redhat.com/browse/OCPSTRAT-831 See: https://issues.redhat.com/browse/OCPSTRAT-113

NEWS: Update for 4.14 stabilization

Fixes: https://github.com/coreos/butane/issues/488

References for this PR:

travier commented 1 year ago

Currently trying to figure out if the MCO supports swap in 4.14 or not.

travier commented 1 year ago

We likely don't support setting up swap yet in openshift (see https://kubernetes.io/blog/2023/08/24/swap-linux-beta/) so maybe we should remove those mentions from the docs.

prestist commented 1 year ago

We likely don't support setting up swap yet in openshift (see https://kubernetes.io/blog/2023/08/24/swap-linux-beta/) so maybe we should remove those mentions from the docs.

Hmm, thats a bit sticky. Once this is stabilized I suspect updates continue to flow into open shift 4.14.0? If so then is there not the likelihood that it will support swap?

travier commented 1 year ago

I've updated some docs elements and finalized the commit messages. This should be ready for a final review and then we can make a new release.