search

coreos / console-login-helper-messages

A set of scripts to show helpful system information to the login terminal.
BSD 3-Clause "New" or "Revised" License
12 stars 21 forks source link

Add CI/automated testing to the master branch of this repository #5

Closed rfairley closed 4 years ago

rfairley commented 5 years ago

Automated testing by installing the console-login-helper-messages* packages on a vanilla {Fedora/Atomic/CentOS} system, starting the systemd units, and checking that the expected output is produced at login (by sshd for motd, agetty for issue, and by the bash terminal for profile) would save time manual testing this.

A build of the RPMs, an install, and a test run should trigger once when a PR is opened.

rfairley commented 5 years ago

Example of basic tests that can be automated: https://github.com/rfairley/console-login-helper-messages/blob/0d6b9c89e3c210640a943d3bae29484ef094cc24/reviewers.md

rfairley commented 5 years ago

32 drops a Vagrantfile that provisions a VM with this package installed. This approach could be used in CI.

rfairley commented 4 years ago

One approach now is to have kola external tests, which coreos-assembler can run either in development or testing environments: https://github.com/coreos/coreos-assembler/blob/master/mantle/kola/README-kola-ext.md

Then the command https://github.com/coreos/coreos-assembler/blob/master/src/cmd-build-fast could be used for local development.

Example of a pipeline: https://github.com/coreos/ignition-dracut/blob/master/.cci.jenkinsfile

This would require adding a make install target, similar to: https://github.com/coreos/ignition-dracut/blob/master/Makefile

We'd also want to unify the make install target with the CLHM RPM specfile at https://src.fedoraproject.org/rpms/console-login-helper-messages/blob/master/f/console-login-helper-messages.spec, to avoid multiple sources of truth.

kelvinfan001 commented 4 years ago

Closed by https://github.com/coreos/console-login-helper-messages/pull/75