search

coreos / container-linux-update-operator

A Kubernetes operator to manage updates of Container Linux by CoreOS
Apache License 2.0
209 stars 49 forks source link

agent: deserialize waitForPodDeletion check. #150

Closed diegs closed 7 years ago

diegs commented 7 years ago

This adds a sync.WaitGroup to check all pods concurrently and avoid erroneously extended grace periods.

dghubble commented 7 years ago

Let's have the WaitGroups be separate and write the UID check to mirror upstream drain (and handle nil) #151.

diegs commented 7 years ago

Ok, do you want me to scope this PR just to the waitgroup fix then?

dghubble commented 7 years ago

Sure

diegs commented 7 years ago

Rebased, though strictly not necessary since no conflicts... cc @euank :)

euank commented 7 years ago

Our repo allows merge commits. Was it indicating otherwise @dghubble?

dghubble commented 7 years ago

Habit, looks like its not enforced, which I'm fine with