search

coreos / container-linux-update-operator

A Kubernetes operator to manage updates of Container Linux by CoreOS
Apache License 2.0
209 stars 49 forks source link

agent: set a label when after successful os-update #168

Closed squeed closed 6 years ago

squeed commented 6 years ago

agent: set a label when after successful os-update

This sets the label container-linux-update.v1.coreos.com/reboot-needed: "true" on nodes where the OS has been upgraded but not yet rebooted. This is so daemonsets like tectonic-torcx can run ASAP.

Fixes: #167

squeed commented 6 years ago

cc @lucab

dghubble commented 6 years ago

Ah, missed #167 which has the background context.

dghubble commented 6 years ago

So can we have the label use the prefix + reboot-needed name? We'll document that CLUO sets the reboot-needed annotation and label in lock-step. Label is easier to write deployments / daemonsets against. Annotation is easier to write programs against.

The fact Tectonic sets CLUO's annotations is an anti-pattern I've tried to squash. CLUO doesn't make guarantees when external apps are setting its own clearly named attributes. So its not a concern for your PR.

squeed commented 6 years ago

Thanks for the feedback; updated. PTAL.

dghubble commented 6 years ago

I have no other issues. Just the point by @sdemos. We can do ship this feature out if needed or wait a bit after merge.

squeed commented 6 years ago

Thanks for the feedback, updated. It would probably be good to release this soon.