search

coreos / coreos-assembler

Tooling container to assemble CoreOS-like systems
https://coreos.github.io/coreos-assembler/
Apache License 2.0
342 stars 167 forks source link

GCP: GCP tarball is wrongly referenced in metadata #1078

Closed yuqi-zhang closed 4 years ago

yuqi-zhang commented 4 years ago

Bug Report

Environment

RHCOS pipeline

Expected Behavior

Generates correct tarball

Actual Behavior

Generates incorrect tarball location

Reproduction Steps

Example failure: https://github.com/openshift/installer/pull/2996

Other Information

Likely due to rework in https://github.com/coreos/coreos-assembler/commit/1dc3cddb393fcab1000ee62908aaadb8d41d8ccd where the reference names were changed

cgwalters commented 4 years ago

Taking this since I think @darkmuggle is travelling.

It seems to me we still have the dividing lines between cosa/mantle here aren't right - in this case, it's ore that's doing the upload, and knows the URL where the content can be found, but we're reconstructing that URL (in this case incorrectly) in cosa.

miabbott commented 4 years ago

Hmm...is this actually fixed?

The last known good build had the following:

"gcp": {
        "image": "rhcos-44-81-202001241431-0",
        "url": "https://storage.googleapis.com/rhcos/rhcos/44.81.202001241431.0.tar.gz"
    }

The next build that failed had:

"gcp": {
        "image": "rhcos-44-81-202001241932-0-gcp-x86-64",
        "url": "https://storage.googleapis.com/rhcos/rhcos/rhcos-44.81.202001241932.0-gcp.x86_64.tar.gz"
    }

And after #1079, I see:

"gcp": {
        "image": "rhcos-44-81-202001291108-0-gcp-x86-64",
        "url": "https://storage.googleapis.com/rhcos/rhcos/rhcos-44-81-202001291108-0-gcp-x86-64.tar.gz"
    }
cgwalters commented 4 years ago

What's wrong with the new one?

yuqi-zhang commented 4 years ago

In the rework we changed the naming schema. The problem was not the new name, but rather a disconnect between the new name of the actual tarball and the new name in the meta.json file

miabbott commented 4 years ago

I failed to notice the subtle changes of dots to dashes in the file name...sorry for the noise!