search

coreos / coreos-assembler

Tooling container to assemble CoreOS-like systems
https://coreos.github.io/coreos-assembler/
Apache License 2.0
335 stars 165 forks source link

add support for `qemu` to denylist processing #2467

Open dustymabe opened 2 years ago

dustymabe commented 2 years ago

Basically if I add an entry to kola-denylist.yaml that looks like:

- pattern: podman.base                                                                                                            
  tracker: https://github.com/coreos/fedora-coreos-tracker/issues/966                                                                        
  snooze: 2021-10-15                                                                                                                         
  platforms:                                                                                                                                 
    - aws                                                                                                                                    
    - gcp                                                                                                                                    
    - qemu

It would be nice if it worked against qemu. Right now you have to use qemu-unpriv.

dustymabe commented 1 year ago

@HuijingHei - is this one solved now with your recent work?

HuijingHei commented 1 year ago

Probably no, could you help to add more description about this?

HuijingHei commented 1 year ago

What I can understand about qemu vs qemu-unpriv is refer to https://github.com/coreos/coreos-assembler/tree/main/mantle#qemu

HuijingHei commented 1 year ago

In case it meant Replace 'qemu-unpriv' with 'qemu', seems https://github.com/coreos/coreos-assembler/pull/3285 is doing this. But it might be old, I will open another PR for this.

dustymabe commented 1 year ago

@HuijingHei - I'm so sorry. I totally confused this qemu/qemu-unpriv work with the recent work you did for gcp/gce in https://github.com/coreos/coreos-assembler/issues/3378.

It was @travier doing the qemu bits (as you found).

HuijingHei commented 1 year ago

@dustymabe No problem.