search

coreos / coreos-assembler

Tooling container to assemble CoreOS-like systems
https://coreos.github.io/coreos-assembler/
Apache License 2.0
342 stars 167 forks source link

Add pipeline stream name to containers as labels #3390

Open jlebon opened 1 year ago

jlebon commented 1 year ago

Feature Request

Desired Feature

The release controller wants to be able to tell from which stream an RHCOS build came from just by looking at its container image as found in the release payload. That way, it can link to the right stream in the RHCOS release browser.

Let's add a label for this to the image to make that easier. For consistency, we should probably add it to all the containers and not just the main one (i.e. the extensions container too).

Example Usage

UX to be discussed. We want to avoid passing switches; that won't work as nicely for the extensions container. Probably simplest is to drop a file in src/ at the top and have cosa pick up on that.

Other Information

See https://github.com/openshift/release-controller/pull/503#discussion_r1131076358 and following.

jlebon commented 1 year ago

We should also fix https://github.com/coreos/coreos-assembler/pull/3480 when we do this.