search

coreos / coreos-assembler

Tooling container to assemble CoreOS-like systems
https://coreos.github.io/coreos-assembler/
Apache License 2.0
335 stars 165 forks source link

fedmsg-broadcast: allow many basearches in `stream.release` msg #3698

Closed jlebon closed 7 months ago

jlebon commented 7 months ago

Right now, when a new build is released, we emit the stream.release message once per architecture. But an important part of the release job is to "integrate" all the different arches into a single release. So it seems much more appropriate to have it emit a single fedmsg and in it, we list out all the arches in that release.

Prep for adding a consumer to that message.

dustymabe commented 7 months ago

Are we changing an API here that something could be consuming already? Do we anticipate any breakage?

jlebon commented 7 months ago

Are we changing an API here that something could be consuming already? Do we anticipate any breakage?

In theory, yes. In practice, I don't think there are any consumers of this message presently. I know OpenQA listens to messages, but only on build.state.change.

On that topic, maybe we should add something like:

{
    "note": "this schema is subject to change; subscribe to ... for changes"
}

to the message body. Currently there isn't really a good way to notify any potential consumers of changes. We should probably also start schema versioning.