search

coreos / coreos-assembler

Tooling container to assemble CoreOS-like systems
https://coreos.github.io/coreos-assembler/
Apache License 2.0
335 stars 165 forks source link

create_disk: update grub2-install invocation to match bootupd #3699

Closed dustymabe closed 7 months ago

dustymabe commented 7 months ago

bootupd calls grub2-install with mdraid1x and part_gpt [1]. We are updating our grub2-install test to match what bootupd is doing for the grub2-install verification [2]. Let's also update create_disk.sh here so the test will pass regardless of whether a disk image was created with create_disk.sh or osbuild (which currently will use bootupd for the bootloader install).

[1] https://github.com/coreos/bootupd/blob/e1be3005d827fc3bacf82a2c2a98cd9c0706c65f/src/bios.rs#L66-L69 [2] https://github.com/coreos/fedora-coreos-config/pull/2810

dustymabe commented 7 months ago

We'll probably have to merge this one without passing tests because this one and https://github.com/coreos/fedora-coreos-config/pull/2810 are tightly coupled.

openshift-ci[bot] commented 7 months ago

@dustymabe: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/rhcos f8614d5960465720562c749c9eb4ddef329d6575 link true /test rhcos

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
dustymabe commented 7 months ago

Closing this as we updated the strategy here as suggested in https://github.com/coreos/fedora-coreos-config/pull/2810#issuecomment-1899324928