testiso - iscsi : misc fixes to improve reliability and disable the test for other arches than x86

jbtrystram commented 7 months ago

fix invalid After targets in iscsi services
rename target container to targetd : Target is a systemd w ord and seems to interfere with systemd, as running systemctl stop target shuts the vm down
add a wait for the targetd container to be ready before configuring the iscsi target. this should be removed when we ship systemd 254 in rhcos
Add a healthcheck to the target container and make sure we mark the systemd service as started only when targetcli is ready to receive commands. Note this is commented out due to an older systemd version in rhcos
update virtserial channel completion channel name to "testisocompletion" to allow the coreos-test-entered-emergency-target.service to write to it, as it expects this name. This will allow correct failure detection rather than waiting for QEMU timeout.
add a restart policy on setup-targetcli as it may start too fast so we allow it to restart before marking it failed. Disabled for now waiting for a systemd update in rhcos

Disable the iscsi test on other arches than x86 : Nested virt does not work through cosa ref https://github.com/coreos/fedora-coreos-tracker/issues/1657

jbtrystram commented 7 months ago

attached console.txt from aarch64 run of iso-offline-install-iscsi.bios it was run with this coreos-assembler changes

jbtrystram commented 7 months ago

@jlebon I rebased the branch, squashed commits with a more detailed commit message and excluded the test from other arches than x86 with a note pointing to https://github.com/coreos/fedora-coreos-tracker/issues/1657

coreos / coreos-assembler