search

coreos / coreos-assembler

Tooling container to assemble CoreOS-like systems
https://coreos.github.io/coreos-assembler/
Apache License 2.0
335 stars 165 forks source link

powervs: make disk name in OVA more descriptive #3708

Closed Poorna-Gottimukkula1 closed 7 months ago

Poorna-Gottimukkula1 commented 7 months ago

Enhancing visibility of OS's in PowerVS "Volumes" view includes providing additional details. IBM i, for example, names their .raw files "IBMi-\-img.raw". Task ref: https://issues.redhat.com/browse/COS-2627

openshift-ci[bot] commented 7 months ago

Hi @Poorna-Gottimukkula1. Thanks for your PR.

I'm waiting for a coreos member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
jlebon commented 7 months ago

Can you provide more context on this? It's very rare that an empty commit message is appropriate. :)

If that filename is very user-visible, then it might make sense to templatize that field and give an even more meaningful name.

clnperez commented 7 months ago

yes, agree on the templatizing. it would be good to have the version in if possible. when we talked before and i suggested just coreos, I wasn't clear about also keeping that part (that you originally had).

jlebon commented 7 months ago

/ok-to-test