coreos / coreos-assembler

Tooling container to assemble CoreOS-like systems

https://coreos.github.io/coreos-assembler/

Apache License 2.0

335 stars 165 forks source link

[kola testiso] iscsi - fix test timeout #3716

Closed jbtrystram closed 7 months ago

jbtrystram commented 7 months ago

3705 should not have been merged :grimacing:

targetd.sock does not exist, even when running systemctl enable targetd.socket so rely on targetcli to succeed instead. Tested on x86

jbtrystram commented 7 months ago

failing test is unrelated to this change : [2024-02-05T09:47:55.332Z] --- FAIL: ext.config.networking.ifname-karg.everyboot-systemd-link-file (603.62s)

travier commented 7 months ago

Is targetcli ls failing with a non zero exit code when it's not ready? I can not find this in https://www.mankier.com/8/targetcli.

travier commented 7 months ago

How did this test pass in the PR before? Edit: The test is currently denylisted.

jbtrystram commented 7 months ago

Is targetcli ls failing with a non zero exit code when it's not ready? I can not find this in mankier.com/8/targetcli.

I did some additional testing and it seems to work (returning zero when ready) but I can't reproduce a slow run with a debug where it's not ready when called. I get non zero exit codes when trying locally with a crashed targetd so that should work :

$ podman exec -it -l targetcli || echo $?
Could not load module: configfs
255