search

coreos / coreos-assembler

Tooling container to assemble CoreOS-like systems
https://coreos.github.io/coreos-assembler/
Apache License 2.0
342 stars 167 forks source link

Drop composefs setting #3732

Closed cgwalters closed 5 months ago

cgwalters commented 8 months ago

Since https://github.com/ostreedev/ostree/pull/3165 this can be configured in the ostree commit itself.

cgwalters commented 8 months ago

xref https://github.com/coreos/fedora-coreos-config/pull/2783

alexlarsson commented 8 months ago

As I commented in https://github.com/ostreedev/ostree/pull/3165, we still rely on the global setting to change the default of use_fsverity from NO to MAYBE. If this is dropped, then composefs with fs-verity will not work.

And really, this needs to be a global options, because objects are shared between images, so even if the image being pulled doesn't use composefs, another may reuse its objects and do use composefs.

jlebon commented 5 months ago

Closing based on https://github.com/coreos/coreos-assembler/pull/3732#issuecomment-1956234090.