search

coreos / coreos-assembler

Tooling container to assemble CoreOS-like systems
https://coreos.github.io/coreos-assembler/
Apache License 2.0
333 stars 165 forks source link

kola/tests: add `openshift` tag to OCP tests #3741

Closed jlebon closed 5 months ago

jlebon commented 5 months ago

This is part of https://github.com/openshift/os/pull/1445.

Those tests are all actually testing OCP components. In the new model, they should be run against an OCP layered image instead. Add a tag on them so that we'll be able to run them separately.

openshift-ci[bot] commented 5 months ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

jlebon commented 5 months ago

Before doing this, we need to tweak things so that those tests keep running in the !layered streams. (A "layered stream" here refers to a stream built using the approach in https://github.com/openshift/os/pull/1445).

Edit: I've changed the approach here to be more incremental: we still add an openshift tag, but it's no longer a RequiredTag, so should have no effect on current streams.

jlebon commented 5 months ago

/retest

jlebon commented 5 months ago

This is now ready for review!

jlebon commented 5 months ago

LGTM!

One question, out of curiosity: Will it become a required tag in the future?

Thanks for reviewing! Yes, probably. Once we've fully switched over to the new stream, then it becomes easier in the pipelines to use required tags so that the kola run on the base compose doesn't have to do --tag !openshift anymore.