search

coreos / coreos-assembler

Tooling container to assemble CoreOS-like systems
https://coreos.github.io/coreos-assembler/
Apache License 2.0
333 stars 165 forks source link

Improve kola argument processing logic for platform specific options #3752

Open itsCheithanya opened 4 months ago

itsCheithanya commented 4 months ago

Improve kola argument processing for platform-specific options Implements logic to automatically infer the platform based on provided options for AWS, Azure, DO, ESX, GCP, OpenStack, and Packet. Ensures platform consistency when using platform-specific options (e.g., --aws-ami). Fixes: https://github.com/coreos/coreos-assembler/issues/3509

openshift-ci[bot] commented 4 months ago

Hi @itsCheithanya. Thanks for your PR.

I'm waiting for a coreos member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
travier commented 4 months ago

I think there are more options to look at to force the platform being used.

Looks like this also needs code formatting.

travier commented 4 months ago

Please use a more descriptive commit message that notably includes at the end:

Fixes: https://github.com/coreos/coreos-assembler/issues/3509
itsCheithanya commented 4 months ago

I think there are more options to look at to force the platform being used.

Looks like this also needs code formatting.

Yes i will add for all of them ,just wanted to know if I'm in the right direction

itsCheithanya commented 4 months ago

Please use a more descriptive commit message that notably includes at the end:

Fixes: https://github.com/coreos/coreos-assembler/issues/3509

Sorry i just made this PR for code clarifications not an actual issue solving one, will make sure to follow it for the coming PR's

travier commented 4 months ago

Yes i will add for all of them ,just wanted to know if I'm in the right direction

Yes, looks like you're going in the right direction.

itsCheithanya commented 4 months ago

@travier

87c8ea4

Made the required code changes for all other platform options ,Let me know if anything needs to be done

aaradhak commented 2 months ago

@travier As part of the backlog refinement, we came across this issue. We wanted to know if this is a relevant issue.