search

coreos / coreos-assembler

Tooling container to assemble CoreOS-like systems
https://coreos.github.io/coreos-assembler/
Apache License 2.0
333 stars 165 forks source link

Add `cosa buildextend-layered` #3753

Closed jlebon closed 3 months ago

jlebon commented 4 months ago

As part of https://github.com/openshift/os/issues/799, we'll want to build the "OCP node" image as a layered image on top of the RHCOS base image.

Eventually, this image should be built outside our pipelines and more like the rest of OpenShift container images. But for now, let's build it ourselves. This allows us to prove out the idea without yet requiring changes in the rest of OpenShift.

The script added here looks wordy, but it's really trivial. It's basically a glorified wrapper around podman build and skopeo copy so that the built OCI image ends up in our meta.json.

openshift-ci[bot] commented 4 months ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

jlebon commented 3 months ago

OK, actually I think I've convinced myself we don't need this intermediate stage. Instead, I think it's better to just go straight to having a follow-on job that builds the image and pushes it to the registry. This makes immediately palpable the distinct phases between the base compose using our usual cosa pipeline vs the layered build, which is how we want it set up in the long run.