search

coreos / coreos-assembler

Tooling container to assemble CoreOS-like systems
https://coreos.github.io/coreos-assembler/
Apache License 2.0
333 stars 165 forks source link

testiso/iscsi add a manual test for no iBFT cases #3757

Closed jbtrystram closed 3 months ago

jbtrystram commented 4 months ago

This test simply changes the kargs from rd.iscsi.firmware=1 to netroot=iscsi... at the coreos-installer step. This will ensure we support no-ibft installations.

Partial fix for https://github.com/coreos/fedora-coreos-tracker/issues/1651

jbtrystram commented 4 months ago

/restest

jlebon commented 4 months ago

Let's clear up https://github.com/openshift/os/pull/1461#issuecomment-1998858271 before merging this so that we don't immediately break the RHCOS pipeline.

jlebon commented 3 months ago

To confirm, did you verify that this passes on RHCOS?

dustymabe commented 3 months ago

To confirm, did you verify that this passes on RHCOS?

tested on rhcos-416.94.202404301731-0-live.x86_64.iso:

Running test: iso-offline-install-iscsi.ibft.bios
PASS: iso-offline-install-iscsi.ibft.bios (3m23.07s)
Running test: iso-offline-install-iscsi.manual.bios
PASS: iso-offline-install-iscsi.manual.bios (3m15.665s)
jbtrystram commented 3 months ago

To confirm, did you verify that this passes on RHCOS?

I think i did at the time, when opening the PR. Thanks @dustymabe for the confirmation