search

coreos / coreos-assembler

Tooling container to assemble CoreOS-like systems
https://coreos.github.io/coreos-assembler/
Apache License 2.0
333 stars 165 forks source link

cmd-prune: don't prune the ostree repo if non-existant #3773

Closed dustymabe closed 4 months ago

dustymabe commented 4 months ago

In cases where we buildfetch a bunch of different builds if we then want to clean some of them up easily with cosa prune it will fail if there is no ostree repo at tmp/repo. Let's just check and if nothing is there then let's not try to clean it up.

dustymabe commented 4 months ago

/retest

openshift-ci[bot] commented 4 months ago

@dustymabe: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/rhcos 544051fcc62ee4a763a1de9ce81d573d8a6fd439 link true /test rhcos

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
dustymabe commented 4 months ago

the CI failure looks like secure boot tests failing on RHCOS: kola-basic/firmware-uefi-secure

jlebon commented 4 months ago

I think what's going on here is that the CI job builds SCOS, but for some reason isn't pulling in centos-release, even though it's specified. And that's what's used to know if to run the SB test.

dustymabe commented 4 months ago

I think what's going on here is that the CI job builds SCOS, but for some reason isn't pulling in centos-release, even though it's specified. And that's what's used to know if to run the SB test.

I'm going to claim here that this change didn't cause that issue so I'm going to merge this.

travier commented 3 months ago

Hum, it might be that the RHEL Beta kernels are still signed with the Beta Secure Boot key and thus testing for the centos-release package being present is not enough.

jlebon commented 3 months ago

Hum, it might be that the RHEL Beta kernels are still signed with the Beta Secure Boot key and thus testing for the centos-release package being present is not enough.

But if you look at the CI logs, it's not building RHCOS, but SCOS. I guess from https://github.com/coreos/coreos-assembler/blob/de0c96152b6af0d07c937d1784eb0b2f81af5743/ci/prow-rhcos.sh#L20

It's really weird that it's not pulling in centos-release in that case.

travier commented 3 months ago

Oh indeed