coreos / coreos-assembler

Tooling container to assemble CoreOS-like systems
https://coreos.github.io/coreos-assembler/
Apache License 2.0
333 stars 165 forks source link

Add tags argument parser for aws_cli #3777

Closed gursewak1997 closed 3 months ago

gursewak1997 commented 3 months ago

Add the ability to add tags to AMIs when running ore aws upload with --tags flag. Can be used as: cosa buildextend-aws --tags foo=bar,abc=xyz or cosa buildextend-aws --tags=foo=bar --tags=abc=xyz

dustymabe commented 3 months ago

Can be used as: cosa buildextend-aws --tags foo=bar,abc=xyz or cosa buildextend-aws --tags="foo=bar,abc=xyz"

I would say:

Can be used as: cosa buildextend-aws --tags foo=bar,abc=xyz or cosa buildextend-aws --tags=foo=bar --tags=abc=xyz

gursewak1997 commented 3 months ago

I would say:

Can be used as: cosa buildextend-aws --tags foo=bar,abc=xyz or cosa buildextend-aws --tags=foo=bar --tags=abc=xyz

Unfortunately that doesn't work but let me see if I can make changes to implement that. Adding multiple --tags ends up only taking the last value.

gursewak1997 commented 3 months ago

I can make changes to implement that.

The new changes should take care of the above.

dustymabe commented 3 months ago

The changes LGTM, but let's "fix" the grant-user* args in an initial (separate) commit to explain things a little better.