search

coreos / coreos-assembler

Tooling container to assemble CoreOS-like systems
https://coreos.github.io/coreos-assembler/
Apache License 2.0
333 stars 165 forks source link

mantle/kola: add a few comments/tweaks to iscsi test #3779

Closed dustymabe closed 3 months ago

dustymabe commented 3 months ago

I had originally started going through iscsi_butane_setup.yaml without the help of the description in testiso.go and I decided to document things myself. Later I found the better description in testiso.go, so let's mention it at the top of the Butane config.

Also made a few tweaks.

dustymabe commented 3 months ago

Maybe we should to move the comments to the butane file, if that's where you expected them. TBH back then i thought i couldn't comment butane files so i put the explanation there

I'm fine with them in the code with a reference back to the description in testiso.go.