search

coreos / coreos-assembler

Tooling container to assemble CoreOS-like systems
https://coreos.github.io/coreos-assembler/
Apache License 2.0
337 stars 166 forks source link

Various test tweaks to make compatible with `--oscontainer` #3784

Closed jlebon closed 5 months ago

jlebon commented 5 months ago

See individual commit messages.

Part of https://github.com/openshift/os/issues/799.

travier commented 5 months ago

And this actually highlights one of the gotchas of the layered OCP work we'll have to keep an eye out for: it will not work to enable services that only exist in the layered image via Ignition, because Ignition uses presets for enablement and presets are only applied on first boot.

This is interesting. This means that we need any service enablement to happen in the container build instead.

Should we move the CRI-O test out of COSA into openshift/os?

jlebon commented 5 months ago

Should we move the CRI-O test out of COSA into openshift/os?

Yeah, it looks like a good candidate for converting to an external test.