search

coreos / coreos-assembler

Tooling container to assemble CoreOS-like systems
https://coreos.github.io/coreos-assembler/
Apache License 2.0
330 stars 165 forks source link

add iscsi+multipath test; add some improvements to test strategy #3789

Closed dustymabe closed 2 months ago

dustymabe commented 2 months ago

See individual commit messages.

dustymabe commented 2 months ago

/cherry-pick rhcos-4.16

openshift-cherrypick-robot commented 2 months ago

@dustymabe: #3789 failed to apply on top of branch "rhcos-4.16":

Applying: mantle/platform/qemu: Adjust dependencies on journal-stream unit
Applying: mantle/platform/qemu: drop json formatting from journal output
Applying: mantle/kola/testiso: fix firmware entries for multi-arch iscsi tests
Using index info to reconstruct a base tree...
M   mantle/cmd/kola/testiso.go
Falling back to patching base and 3-way merge...
Auto-merging mantle/cmd/kola/testiso.go
CONFLICT (content): Merge conflict in mantle/cmd/kola/testiso.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0003 mantle/kola/testiso: fix firmware entries for multi-arch iscsi tests
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
In response to [this](https://github.com/coreos/coreos-assembler/pull/3789#issuecomment-2099000949): >/cherry-pick rhcos-4.16 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
jlebon commented 2 months ago

Follow-up in https://github.com/coreos/coreos-assembler/pull/3799.