search

coreos / coreos-assembler

Tooling container to assemble CoreOS-like systems
https://coreos.github.io/coreos-assembler/
Apache License 2.0
337 stars 166 forks source link

cmdlib.sh: add env var to sleep before killing `tail` #3792

Closed jlebon closed 5 months ago

jlebon commented 5 months ago

I can't reproduce this locally, but I have a suspicion that tail can exit too quickly in some circumstances, causing truncated output:

https://github.com/openshift/os/pull/1498#issuecomment-2096598277 https://github.com/coreos/coreos-assembler/pull/3785#discussion_r1591387449

Rather than having an unconditional sleep, let's make it easier to test that theory by having an env var we can use to make it optional. Then we'll test that in CI.

Mid-term, I'd like to revert 79b15c89d soon so we can go back to virtio-serial which is just so much cleaner.

jlebon commented 5 months ago

/retest

jlebon commented 5 months ago

/retest

openshift-ci[bot] commented 5 months ago

@jlebon: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/rhcos 990a0a7821014dc5ecb649b3f6413bc8b4f3c1da link true /test rhcos
ci/prow/images 990a0a7821014dc5ecb649b3f6413bc8b4f3c1da link true /test images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
jlebon commented 5 months ago

Interesting. Prow is still hitting:

Error: Unable to find a match: osbuild-114-1.fc40.noarch osbuild-ostree-114-1.fc40.noarch osbuild-selinux-114-1.fc40.noarch osbuild-tools-114-1.fc40.noarch

But I did tag it into the continuous tag and the repo was already regenerated. CoreOS CI at least is happy now. That repo isn't mirrored AFAIK though I wonder if Prow is somehow hitting an old version.