search

coreos / coreos-assembler

Tooling container to assemble CoreOS-like systems
https://coreos.github.io/coreos-assembler/
Apache License 2.0
330 stars 165 forks source link

testiso: add rw karg to iSCSI multipath test #3797

Closed jlebon closed 2 months ago

jlebon commented 2 months ago

This is required by ostree.

This sometimes worked I think because ignition-remount-sysroot.service has no ordering against ostree-prepare-root.service and so they'd race. But really, we shouldn't rely on that Ignition unit.

See also: https://github.com/coreos/coreos-assembler/pull/3789#discussion_r1591769493

jlebon commented 2 months ago

Hmm, Prow failing on ext.config.systemd.journal-compat. I saw that on another PR as well. We'll have to debug that.

But let's get this in to unbreak upstream CIs that run kola testiso.

/override ci/prow/rhcos

openshift-ci[bot] commented 2 months ago

@jlebon: Overrode contexts on behalf of jlebon: ci/prow/rhcos

In response to [this](https://github.com/coreos/coreos-assembler/pull/3797#issuecomment-2101301861): >Hmm, Prow failing on `ext.config.systemd.journal-compat`. I saw that on another PR as well. We'll have to debug that. > >But let's get this in to unbreak upstream CIs that run `kola testiso`. > >/override ci/prow/rhcos Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
jlebon commented 2 months ago

Hmm, Prow failing on ext.config.systemd.journal-compat. I saw that on another PR as well. We'll have to debug that.

Filed https://github.com/openshift/os/issues/1505 since it doesn't look like a flake.