search

coreos / coreos-assembler

Tooling container to assemble CoreOS-like systems
https://coreos.github.io/coreos-assembler/
Apache License 2.0
337 stars 166 forks source link

build.sh: remove edk2-ovmf version freeze #3818

Closed yasminvalim closed 4 months ago

yasminvalim commented 4 months ago

We temporarily froze updates to that version due to issues with the FCOS PXE 4K UEFI tests. You can check it here: https://github.com/coreos/coreos-assembler/pull/3816.

Now that we had a update to fix it, we can switch back to the latest version.

jlebon commented 4 months ago

This is totally fine, though a more idiomatic way to do this would be to use git revert to revert the commit that froze the package. That makes it more obvious that it's a revert and links to the original commit. But still add to the generated commit message more information about why we can now revert the commit.

Also, can you make sure that your commit messages wrap at some reasonable column (usually 72)?

yasminvalim commented 4 months ago

This is totally fine, though a more idiomatic way to do this would be to use git revert to revert the commit that froze the package. That makes it more obvious that it's a revert and links to the original commit. But still add to the generated commit message more information about why we can now revert the commit.

Also, can you make sure that your commit messages wrap at some reasonable column (usually 72)?

Thanks! I updated the commit to be a revert. I've left the default revert message. Let me know if it's okay.

jlebon commented 4 months ago

Prow will likely fail on https://github.com/openshift/os/issues/1523#issuecomment-2153161111; we can override it if so.

jlebon commented 4 months ago

/override ci/prow/rhcos

openshift-ci[bot] commented 4 months ago

@jlebon: Overrode contexts on behalf of jlebon: ci/prow/rhcos

In response to [this](https://github.com/coreos/coreos-assembler/pull/3818#issuecomment-2153742182): >/override ci/prow/rhcos Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.