coreos / coreos-assembler

Tooling container to assemble CoreOS-like systems
https://coreos.github.io/coreos-assembler/
Apache License 2.0
335 stars 165 forks source link

prow: add a OWNERS file #3835

Closed jbtrystram closed 1 month ago

jbtrystram commented 1 month ago

This allows us to have permissions to /override prow tests among other things. Currently this is limited to repo administrator but an OWNERS files makes it easier to manage. This is a copy from the openshift/os repo.

travier commented 1 month ago

Hum, I think it's in https://github.com/openshift/release/blob/master/ci-operator/config/coreos/coreos-assembler/OWNERS

travier commented 1 month ago

which is https://github.com/openshift/release/blob/master/OWNERS_ALIASES#L99 & https://github.com/openshift/release/blob/master/OWNERS_ALIASES#L119

Is something not working as expected?

jbtrystram commented 1 month ago

@travier I created that because I hit https://github.com/coreos/coreos-assembler/pull/3826#issuecomment-2232609836

travier commented 1 month ago

OK, let's get this list cleaned-up here (and in openshift/os as needed as well).

travier commented 1 month ago

and openshift/release as well

jbtrystram commented 1 month ago

@travier updated . related PRs:

jlebon commented 1 month ago

Hmm, but actually instead of this, don't we just want OWNERS_ALIASES with the coreos-approvers alias? That way, we maintain a single list of users in openshift/release.

jbtrystram commented 1 month ago

It's totally fine IMO to just manually merge things if one of the Prow tests is flaking and you know the change isn't covered by it anyway.

I am pretty sure I am not able to. I think only repository admins can merge ignoring checks. image

I can't do anything more than this

travier commented 1 month ago

Note that you need to disable auto-merge to get the UI to bypass the checks. But I agree that it's only available to repo admins as it comes with risks.

So overall it's better to have those Prow commands work.

jbtrystram commented 1 month ago

@jlebon from what I understand of the documentation, OWNER-ALIASES only work

Hmm, but actually instead of this, don't we just want OWNERS_ALIASES with the coreos-approvers alias? That way, we maintain a single list of users in openshift/release.

yeah, did some more reading and testing, this does not work