Closed jbtrystram closed 1 month ago
which is https://github.com/openshift/release/blob/master/OWNERS_ALIASES#L99 & https://github.com/openshift/release/blob/master/OWNERS_ALIASES#L119
Is something not working as expected?
@travier I created that because I hit https://github.com/coreos/coreos-assembler/pull/3826#issuecomment-2232609836
OK, let's get this list cleaned-up here (and in openshift/os as needed as well).
and openshift/release as well
@travier updated . related PRs:
Hmm, but actually instead of this, don't we just want OWNERS_ALIASES
with the coreos-approvers
alias? That way, we maintain a single list of users in openshift/release.
It's totally fine IMO to just manually merge things if one of the Prow tests is flaking and you know the change isn't covered by it anyway.
I am pretty sure I am not able to. I think only repository admins can merge ignoring checks.
I can't do anything more than this
Note that you need to disable auto-merge to get the UI to bypass the checks. But I agree that it's only available to repo admins as it comes with risks.
So overall it's better to have those Prow commands work.
@jlebon from what I understand of the documentation, OWNER-ALIASES only work
Hmm, but actually instead of this, don't we just want
OWNERS_ALIASES
with thecoreos-approvers
alias? That way, we maintain a single list of users in openshift/release.
yeah, did some more reading and testing, this does not work
This allows us to have permissions to
/override
prow tests among other things. Currently this is limited to repo administrator but an OWNERS files makes it easier to manage. This is a copy from the openshift/os repo.