search

coreos / coreos-assembler

Tooling container to assemble CoreOS-like systems
https://coreos.github.io/coreos-assembler/
Apache License 2.0
335 stars 165 forks source link

Minor fixes: Fix FCOS version check and error return for `delete_gcp_image` #3838

Closed gursewak1997 closed 1 month ago

gursewak1997 commented 1 month ago

We have few older builds for testing-devel which had .dev in their buildIDs. Fixed the version check to accept that. Also fixed the return statement in delete_gcp_image to return empty errors list instead on returning None as needed.

aaradhak commented 1 month ago

Looks like the prow job failed here

gursewak1997 commented 1 month ago

/test rhcos

aaradhak commented 1 month ago

Looks like prow is down.

travier commented 1 month ago

/override ci/prow/rhcos

openshift-ci[bot] commented 1 month ago

@travier: Overrode contexts on behalf of travier: ci/prow/rhcos

In response to [this](https://github.com/coreos/coreos-assembler/pull/3838#issuecomment-2255410778): >/override ci/prow/rhcos Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.