search

coreos / coreos-assembler

Tooling container to assemble CoreOS-like systems
https://coreos.github.io/coreos-assembler/
Apache License 2.0
347 stars 168 forks source link

[ppc64le] Remove P8 and P9 hack so tests pass for Power10 #3887

Closed mtarsel closed 1 month ago

mtarsel commented 2 months ago

008e04c322e99cdb769cdb36c010810c8625376b and a6d7bbbadc8f091afbd6732b18fd4aa5a25c4590 added and used the libguestfs-ppc64le-wrapper.sh in order to address some failing tests on ppc64le. Using a Power10 machine with KVM enabled, tests are passing with this script removed. There was a successful test run with: cosa kola run --tag '!reprovision'

If we are going to use p10 for CI going forward, I think we can remove this script entirely. Otherwise, we will have to distinguish between p10 and not p10 or possibly implement a better way than relying on using uname -r output searching for el7.

Related to issue https://github.com/coreos/coreos-assembler/issues/2473

openshift-ci[bot] commented 2 months ago

Hi @mtarsel. Thanks for your PR.

I'm waiting for a coreos member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
marmijo commented 2 months ago

/ok-to-test

ravanelli commented 2 months ago

This looks sane to me. Though I'm still confused why you were hitting issues with this. Those paths shouldn't have triggered for you at all. Probably worth digging into that a bit more to understand better what went wrong there.

But anyway, I do also think that these patches are no longer relevant now. They predate the pipeline rework from a time when we were using a separate ppc64le OCP cluster, which is what I think was what was using RHEL7. Our current builders all use FCOS, so this will never trigger.

cc @ravanelli in case I'm missing something

I think we are ok in removing it, the main reason in the past was indeed the need for vsmt=8 + some other small changes for RHEL7 in our old ocp cluster. However, I agreed this code should not be running in P10 with another RHEL version.

jlebon commented 2 months ago

LGTM. Can you fix the lint issues in the file you touched?

mtarsel commented 2 months ago

LGTM. Can you fix the lint issues in the file you touched?

sure thing. if im reading it correctly, it looks like I need to just remove the unused "unix" import

mtarsel commented 1 month ago

Im not sure why this issue was closed. I did a Sync Fork from the github website and that added the merge commit to this PR however when I did a pull on my branch locally, the merge commit was not present. I did a reset and I guess that automatically closed this.

The branch should be clean now. Reopening and hoping github picks up the same branch