search

coreos / coreos-assembler

Tooling container to assemble CoreOS-like systems
https://coreos.github.io/coreos-assembler/
Apache License 2.0
347 stars 168 forks source link

osbuild: Add Live ISO/PXE build support #3976

Closed dustymabe closed 4 days ago

dustymabe commented 6 days ago

This backports and takes advantage of the new org.osbuild.coreos.live-artifacts.mono stage.

openshift-ci[bot] commented 6 days ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

dustymabe commented 6 days ago

currently this is still WIP but it's getting closer.

jlebon commented 4 days ago

Pushed a few minor fixes.

cosa diff is clean. kola testiso -S is clean. On all arches. LGTM.

I'm pretty comfortable with getting this in and turning it on in rawhide at this point.

jlebon commented 4 days ago

Also, I think I'll turn it on in the 9.6 streams in RHCOS since those are not being consumed yet by a wider audience and I didn't test RHCOS with this change so far (though I don't really expect any issues). It'll also make it easier for the AI/ABI folks to poke at it, and bundling it with 9.6 is a nice switchover point so that it gets validated in OCP together with 9.6 validation.

jlebon commented 4 days ago

Test fixture option seems to be working fine:

$ ls -l builds/latest/x86_64/*.iso
-r--r--r--. 1 jlebon jlebon 1048576 Nov 27 16:47 builds/latest/x86_64/fedora-coreos-41.20241127.dev.0-live-iso.x86_64.iso

which is in line with sizes in https://github.com/coreos/coreos-installer/tree/main/fixtures/iso once compressed. Using e.g. coreos-installer iso kargs modify on it works as expected.

gursewak1997 commented 4 days ago

I see that we added a few more patches to patch_osbuild. Should I keep them when I bump to Fedora 41 since we were initially deleting the call to this function. Or should I just remove the old patches and keep the new patches that were added in this PR?