Closed prestist closed 3 months ago
Executing(%build): /bin/sh -e /var/tmp/rpm-tmp.VH3P7n
+ umask 022
+ cd /builddir/build/BUILD
+ cd coreos-installer-0.22.1
+ /usr/bin/env CARGO_HOME=.cargo /usr/bin/cargo build --release -j128
error: package `serde_with v3.9.0` cannot be built because it requires rustc 1.67 or newer, while the currently active rustc version is 1.66.1
Either upgrade to rustc 1.67 or newer, or use
cargo update -p serde_with@3.9.0 --precise ver
where `ver` is the latest version of `serde_with` supporting rustc 1.66.1
error: Bad exit status from /var/tmp/rpm-tmp.VH3P7n (%build)
Hmm; it looks like we will not be able to build rhel for this release and bank on it getting delivered by c9s. cannot build rhel due to msrv.
Since RHEL is not releasable and c9s is now in progress; closing upstream issue.
Release process
This project uses cargo-release in order to prepare new releases, tag and sign the relevant git commit, and publish the resulting artifacts to crates.io. The release process follows the usual PR-and-review flow, allowing an external reviewer to have a final check before publishing.
In order to ease downstream packaging of Rust binaries, an archive of vendored dependencies is also provided (only relevant for offline builds).
Requirements
This guide requires:
git
cargo
(suggested: latest stable toolchain from rustup)cargo-release
(suggested:cargo install -f cargo-release
)cargo vendor-filterer
(suggested:cargo install -f cargo-vendor-filterer
)Release checklist
These steps show how to release version
x.y.z
on theorigin
remote (this can be checked viagit remote -av
). Push access to the upstream repository is required in order to publish the new tag and the PR branch.:warning:: if
origin
is not the name of the locally configured remote that points to the upstream git repository (i.e.git@github.com:coreos/coreos-installer.git
), be sure to assign the correct remote name to theUPSTREAM_REMOTE
variable.prepare environment:
RELEASE_VER=x.y.z
UPSTREAM_REMOTE=origin
git checkout -b pre-release-${RELEASE_VER}
check
Cargo.toml
for unintended increases of lower version bounds:git diff $(git describe --abbrev=0) Cargo.toml
update all dependencies:
cargo update
git add Cargo.lock && git commit -m "cargo: update dependencies"
write release notes:
docs/release-notes.md
git add docs/release-notes.md && git commit -m "docs/release-notes: update for release ${RELEASE_VER}"
land the changes:
docs/release-notes.md
changes into mainmake sure the project is clean:
cargo-release
andcargo-vendor-filterer
are up to date:cargo install cargo-release cargo-vendor-filterer
git checkout main && git pull ${UPSTREAM_REMOTE} main
cargo vendor-filterer target/vendor
cargo test --all-features --config 'source.crates-io.replace-with="vv"' --config 'source.vv.directory="target/vendor"'
cargo clean
git clean -fd
create release commit on a dedicated branch and tag it (the commit and tag will be signed with the GPG signing key you configured):
git checkout -b release-${RELEASE_VER}
cargo release --execute ${RELEASE_VER}
(and confirm the version when prompted)open and merge a PR for this release:
git push ${UPSTREAM_REMOTE} release-${RELEASE_VER}
publish the artifacts (tag and crate):
git checkout v${RELEASE_VER}
grep "^version = \"${RELEASE_VER}\"$" Cargo.toml
produces outputgit push ${UPSTREAM_REMOTE} v${RELEASE_VER}
cargo publish
assemble vendor archive:
cargo vendor-filterer --format=tar.gz --prefix=vendor target/coreos-installer-${RELEASE_VER}-vendor.tar.gz
publish this release on GitHub:
target/coreos-installer-${RELEASE_VER}-vendor.tar.gz
sha256sum target/package/coreos-installer-${RELEASE_VER}.crate
sha256sum target/coreos-installer-${RELEASE_VER}-vendor.tar.gz
update the
release
tag on Quay:release
, and confirmclean up the local environment (optional, but recommended):
cargo clean
git checkout main
git pull ${UPSTREAM_REMOTE} main
git push ${UPSTREAM_REMOTE} :pre-release-${RELEASE_VER} :release-${RELEASE_VER}
git branch -d pre-release-${RELEASE_VER} release-${RELEASE_VER}
Fedora packaging:
rust-coreos-installer
spec file in FedoraVersion
Release
back to1%{?dist}
spectool -g -S rust-coreos-installer.spec
kinit your_fas_account@FEDORAPROJECT.ORG
fedpkg new-sources $(spectool -S rust-coreos-installer.spec | sed 's:.*/::')
fedpkg build
rust-coreos-installer
forPackages
link to GitHub release
"Update name
blankType
,Severity
andSuggestion
can be left asunspecified
unless it is a security release. In that case selectsecurity
with the appropriate severity.Stable karma
andUnstable
karma can be set to2
and-1
, respectively.RHCOS packaging:
Version
Release
back to1%{?dist}
spectool -g -S coreos-installer.spec
kinit your_account@IPA.REDHAT.COM
rhpkg new-sources $(spectool -S coreos-installer.spec | sed 's:.*/::')
rhpkg build
CentOS Stream 9 packaging:
rebase-c9s-coreos-installer
issue in the internal team-operations repo and follow the steps there