Switch from `lsblk --pairs` to `lsblk --json`

coreos / coreos-installer

Installer for CoreOS disk images

https://coreos.github.io/coreos-installer/

Apache License 2.0

221 stars 92 forks source link

Switch from `lsblk --pairs` to `lsblk --json` #516

Open jlebon opened 3 years ago

jlebon commented 3 years ago

lsblk supports --json, which would be much nicer to work with using serde than to parse the --pairs output using regex.

lucab commented 3 years ago

I think we already had this but we reverted in https://github.com/coreos/coreos-installer/pull/95 because CentOS 7 didn't support that. Did something change in the meanwhile and we are reinstating this?

jlebon commented 3 years ago

I think we already had this but we reverted in #95 because CentOS 7 didn't support that. Did something change in the meanwhile and we are reinstating this?

Thanks for bringing this up! I wasn't aware of this.

We discussed this during open discussion and since we haven't had CentOS/RHEL7 at all on our radar, it's possible that compatibility for it broke a long time ago already. The proposed path forward is:

Try to build latest coreos-installer on CentOS/RHEL7.
- If it doesn't work and would require a lot of effort to get it working, then let's clearly declare it as unsupported and point people towards using it as a container instead.
- If it still works well, or only requires minor adaptations, then let's keep supporting it, including adding it in CI, and holding off on enhancements like this one which would break compatibility. We can then discuss a deprecation period after which we point people towards using it as a container instead.

At least EPEL it seems has been receiving the latest Rust updates together with Fedora, so it shouldn't be limited by the toolchain.

nikita-dubrovskii commented 3 years ago

So, bad news:

coreos-installer could be built on CentOS7 (using rust from epel)
coreos-installer still works on CentOS7
CentOS7 still has old lsblk with no --json support

Update 13.10.2021:

coreos-installer succeeds installing RHCOS (up to 4.9-8.4)
coreos-installer is only able to install FCOS only without ignition config (cannot mount its boot partition)
written above is also valid for containerized coreos-installer

jlebon commented 3 years ago

Ahh thanks for testing @nikita-dubrovskii. In that case, let's hold this off as discussed. We should open a separate ticket for adding it to CI.