Open jescarri opened 5 years ago
Can one of the admins verify this patch?
Can one of the admins verify this patch?
Can one of the admins verify this patch?
Hi @hexfusion any feedback on this PR?
Thanks!
@hasbro17 @hongchaodeng @xiang90 @fanminshi @rjtsdl
Hey guys sorry for the direct reach, can I get some help on this PR?.
Thanks!
LGTM overall, can we use basic http rather than introduce garrilia router? My point is, it is not exporting other path except /metrics. A simple http.Handle should be enough.
@rjtsdl done, removed the gorilla mux dependency.
Added prometheus exporter for the etcd-backup-operator.