search

coreos / etcd-operator

etcd operator creates/configures/manages etcd clusters atop Kubernetes
https://coreos.com/blog/introducing-the-etcd-operator.html
Apache License 2.0
1.75k stars 740 forks source link

ADDED: prometheus exporter for backup-operator #2096

Open jescarri opened 5 years ago

jescarri commented 5 years ago

Added prometheus exporter for the etcd-backup-operator.

etcd-bot commented 5 years ago

Can one of the admins verify this patch?

etcd-bot commented 5 years ago

Can one of the admins verify this patch?

etcd-bot commented 5 years ago

Can one of the admins verify this patch?

jescarri commented 5 years ago

Hi @hexfusion any feedback on this PR?

Thanks!

jescarri commented 5 years ago

@hasbro17 @hongchaodeng @xiang90 @fanminshi @rjtsdl

Hey guys sorry for the direct reach, can I get some help on this PR?.

Thanks!

rjtsdl commented 5 years ago

LGTM overall, can we use basic http rather than introduce garrilia router? My point is, it is not exporting other path except /metrics. A simple http.Handle should be enough.

jescarri commented 5 years ago

@rjtsdl done, removed the gorilla mux dependency.