search

coreos / etcd-operator

etcd operator creates/configures/manages etcd clusters atop Kubernetes
https://coreos.com/blog/introducing-the-etcd-operator.html
Apache License 2.0
1.75k stars 741 forks source link

fix sort, with a helper so the sort is done 'naturally' #2099

Open jurgenweber opened 5 years ago

jurgenweber commented 5 years ago

Please read https://github.com/coreos/etcd-operator/blob/master/CONTRIBUTING.md#contribution-flow

I hit the edge case that when it sorts, it thinks

etcd_v1066060_2019-07-02-02:51:51 is smaller/older than etcd_v999523_2019-06-30-14:56:49

because it is sorting on the first digit only.

Added all the stuff needed to sort this properly.

right now the periodic backup is continually deleting the same file.

etcd-bot commented 5 years ago

Can one of the admins verify this patch?

etcd-bot commented 5 years ago

Can one of the admins verify this patch?

etcd-bot commented 5 years ago

Can one of the admins verify this patch?

jurgenweber commented 5 years ago

so I built the image and used it overnight, it works as expected now.

Thanks