search

coreos / etcd-operator

etcd operator creates/configures/manages etcd clusters atop Kubernetes
https://coreos.com/blog/introducing-the-etcd-operator.html
Apache License 2.0
1.75k stars 741 forks source link

Operator ignores update event when only PodPolicy changes #2157

Open evgenii-petrov-arrival opened 4 years ago

evgenii-petrov-arrival commented 4 years ago

I'm running operator v0.9.4 .

When changing resource limits in PodPolicy, I'm getting the following log message, and no actual change to pods:

time="2020-02-07T12:04:36Z" level=info msg="ignoring update event: v1beta2.ClusterSpec{Size:3, Repository:\"quay.io/coreos/etcd\", Version:\"3.3.18\", Paused:false, Pod:(*v1beta2.PodPolicy)(0xc0004f90e0), TLS:(*v1beta2.TLSPolicy)(nil)}" cluster-name=loki-etcd cluster-namespace=loki pkg=cluster

isSpecEqual appears to not take PodPolicy into account at all.

Expected behaviour: change to PodPolicy is applied to the pods.