Closed zonggen closed 4 years ago
The updated directory structure is:
.
├── commons
│ ├── Cargo.toml
│ └── src
│ ├── graph.rs
│ ├── lib.rs
│ ├── metadata.rs
│ └── metrics.rs
├── dumnati
│ ├── Cargo.toml
│ └── src
│ ├── graph.rs
│ ├── main.rs
│ ├── metadata.rs
│ ├── metrics.rs
│ ├── policy.rs
│ └── scraper.rs
├── graph-builder
│ ├── Cargo.toml
│ └── src
│ ├── main.rs
│ ├── policy.rs
│ └── scraper.rs
└──policy-engine
├── Cargo.toml
└── src
├── main.rs
├── policy.rs
└── scraper.rs
The dumnati directory remains untouched and its content has been split into commons
, graph-builder
and policy-engine
. @lucab is this overall structure somehow reasonable?
@zonggen yes the hierarchy looks ok. I'd just call the two binaries fcos-graph-builder
and fcos-policy-engine
so that it makes it easier to slowly move in the other repository without impacting existing code upfront.
By the way you'll need to bring https://github.com/coreos/fedora-coreos-cincinnati/pull/18 into this.
fcos-graph-builder
and fcos-policy-engine
, also for the variables mentioned in previous reviewsfcos-policy-engine
so that it turns an empty graph now./commons
. So now the structure looks like:
├── commons
│ ├── Cargo.toml
│ └── src
│ ├── graph.rs
│ ├── lib.rs
│ ├── metadata.rs
│ ├── policy.rs
│ └── metrics.rs
├── dumnati
│ ├── Cargo.toml
│ └── src
│ ├── graph.rs
│ ├── main.rs
│ ├── metadata.rs
│ ├── metrics.rs
│ ├── policy.rs
│ └── scraper.rs
├── fcos-graph-builder
│ ├── Cargo.toml
│ └── src
│ ├── main.rs
│ └── scraper.rs
└──fcos-policy-engine
├── Cargo.toml
└── src
└── main.rs
Verify the behaviors:
, which look sane to me.
Thanks! Both output and patch looks fine. Travis is red due to a few minor linting errors. Other than that, this should be ok to land.
@zonggen while rebasing, you may also want to include https://github.com/coreos/fedora-coreos-cincinnati/pull/20 here.
Re-based on top of master.
Also adjust according to Travis CI https://travis-ci.com/github/zonggen/fedora-coreos-cincinnati/jobs/360895796 where failing at cargo clippy -- -D warnings
This changes splits dumnati to two binaries and a library crate. No content changes are added and only directory structure changes.
Related: https://github.com/coreos/fedora-coreos-cincinnati/issues/3 Signed-off-by: Allen Bai abai@redhat.com