search

coreos / fedora-coreos-config

Base configuration for Fedora CoreOS
Other
153 stars 157 forks source link

[rhcos-4.18] 07fix-selinux-labels: fix service ordering #3273

Closed mike-nguyen closed 1 week ago

mike-nguyen commented 1 week ago

This fixes a mistake in b182027. Before/After directives need to go in the [Unit] section, not [Service].

(cherry picked from commit e2c37dbec85c3853424cc31d79f9bfd18ba8a1eb)

Backporting this to the rhcos-4.18 branch per https://github.com/openshift/os/pull/1644#issuecomment-2485860058

dustymabe commented 1 week ago

since zincati doesn't run in RHCOS not sure this will make much of a difference, but will maybe get rid of a warning/log message.

jlebon commented 1 week ago

Hmm, CI isn't meaningful here. Let's just get this in?

jlebon commented 1 week ago

Wait, I think something got messed up. This is opened against testing-devel not rhcos-4.18. We of course already have this commit in testing-devel, but somehow the GitHub UI made it seem like we didn't. The PR is marked as merged, but AFAICT nothing was actually pushed to testing-devel. Hmm, this is possibly by design though it would've been nice to make it clearer in the UI.

Anyway, all this to say, I think we still need a PR against rhcos-4.18 with that cherry-pick.

dustymabe commented 1 week ago

We of course already have this commit in testing-devel, but somehow the GitHub UI made it seem like we didn't.

super weird

mike-nguyen commented 1 week ago

Opened https://github.com/coreos/fedora-coreos-config/pull/3276 targeting the correct branch