coreos / fedora-coreos-docs

Documentation for Fedora CoreOS
https://docs.fedoraproject.org/en-US/fedora-coreos/
Other
49 stars 119 forks source link

os-extensions: vim is not a good example #396

Open zhenya-1007 opened 2 years ago

zhenya-1007 commented 2 years ago

I believe VIM is an extremely poor example that, if anything, undercuts the pro-containers message the documentation as a whole is trying to make, for these reasons:

Please replace VIM with an example that makes sense in the context this page is trying to illustrate.

Here are some suggestions:

zhenya-1007 commented 2 years ago

@bgilbert Please take the time to provide a reason for closing, should you chose to close it again.

bgilbert commented 2 years ago

Thanks for rewording the issue description. vim is a simple example, but I agree that it's not a great one for the reasons you mentioned. If you'd like to work on this yourself, we'd certainly accept a PR with a more complex example. (Of the ones you mentioned, OpenVPN seems the least controversial.) Otherwise, we may not get to this soon, but it'll hopefully be addressed in due course.

zhenya-1007 commented 2 years ago

Thank you for your comments! What's your take on ZFS vis-a-vis OpenVPN as an example?

dustymabe commented 2 years ago

This particular OS Extensions example is useful because we did change the default text editor (as Fedora did) to nano and so we can point people at this when they want to switch it back, though arguably we could move that bit to a different section and just show setting $EDITOR to vi and not the layering vim part.

Thank you for your comments! What's your take on ZFS vis-a-vis OpenVPN as an example?

I think the goal is to keep the example simple. If we were to change it or add a new example I'd probably keep ZFS out of it and just stick with OpenVPN.

travier commented 2 years ago

I would prefer we add a new example and keep this one. As Dusty said, we need this specific example to point people to when then need vim and not vi/nano.

bgilbert commented 2 years ago

:+1: to adding an additional example. ZFS would work (and is arguably a better example than OpenVPN), with one caveat: it'd need to be zfs-fuse rather than an implementation with a CDDL-licensed kernel module. Fedora doesn't ship the ZFS kernel module due to CDDL/GPL incompatibility, and I don't think we should officially document a combination that Fedora can't ship.