search

coreos / fedora-coreos-pinger

Telemetry service to be used in Fedora CoreOS (see https://github.com/coreos/fedora-coreos-tracker/issues/86)
Apache License 2.0
15 stars 7 forks source link

*: make config groups optional #2

Closed rfairley closed 5 years ago

rfairley commented 5 years ago

Previously, both the reporting and collecting groups had to be specified in every config snippet in order for the TOML parsing to succeed. Instead make the groups and their keys optional, and later perform validation for keys that are required (such as reporting.enabled) once all the snippets have been parsed.

This implicitly makes the default collecting.level value "minimal", which only takes effect if metrics reporting is enabled.

rfairley commented 5 years ago

Since this is still an initial MVP (just a clean-up of #1), going to merge this. Can work out any issues later on.