service: drop requirement on network-online.target

coreos / fedora-coreos-pinger

Telemetry service to be used in Fedora CoreOS (see https://github.com/coreos/fedora-coreos-tracker/issues/86)

Apache License 2.0

15 stars 7 forks source link

service: drop requirement on network-online.target #41

Closed jlebon closed 3 years ago

jlebon commented 3 years ago

As per systemd recommendations[1], we should avoid depending on this unit. Instead, if/when we do implement the reporting bits, we should be resilient to networks taking time to come online or temporary network flakes.

This is the only thing which is actively pulling in network-online.target right now (the other one being docker.service, but we have less control over that one, and it's disabled by default).

[1] https://www.freedesktop.org/wiki/Software/systemd/NetworkTarget/

jlebon commented 3 years ago

Wasn't sure if we wanted to cut a release for this. Started a backport in https://src.fedoraproject.org/rpms/rust-fedora-coreos-pinger/pull-request/4.