search

coreos / fedora-coreos-pinger

Telemetry service to be used in Fedora CoreOS (see https://github.com/coreos/fedora-coreos-tracker/issues/86)
Apache License 2.0
15 stars 7 forks source link

use liboverdrop crate #7

Closed rfairley closed 5 years ago

rfairley commented 5 years ago

Use the API provided by https://github.com/overdrop/liboverdrop-rs/pull/1.

rfairley commented 5 years ago

Accidentally pushed https://github.com/rfairley/fedora-coreos-metrics-client/commit/63f903631d3a68cf0ac70fcdfbff1b69a51f55aa to master, closing this PR. This was a simple change to adapt to the changes in the liboverdrop master - so I think it is OK not to revert it. A follow-up can be done soon to use the liboverdrop crate once published.

lucab commented 5 years ago

I guess this means we now need to release and fedora-package liboverdrop before being able to release and package this. Timewise, do you think it's fine?

rfairley commented 5 years ago

Right, yes this does make packaging liboverdrop a blocker. The packaging for liboverdrop should be straightforward, but I don't want to rush work there for this. I'll revert this now - less harm done.

I did build an RPM ready go here for FCOS, but we may still want to add changes upstream (in this repo) before packaging this. Shouldn't block more changes being added based on my accidental push.

rfairley commented 5 years ago

Superseded by: #10