search

coreos / fleet

fleet ties together systemd and etcd into a distributed init system
Apache License 2.0
2.42k stars 302 forks source link

functional: write machine ID into nspawn container #1596

Closed dongsupark closed 8 years ago

dongsupark commented 8 years ago

As systemd v230 or newer requires /etc/machine-id on a nspawn container, we need to write the container's own machine ID into /etc/machine-id. Otherwise, functional tests don't start at all like:

  --- FAIL: TestKnownHostsVerification (10.80s)
    client_test.go:36: unable to detect machine PID

Fixes: https://github.com/coreos/fleet/issues/1594 See also https://github.com/systemd/systemd/pull/3014 See also https://github.com/coreos/rkt/pull/2440

jonboulle commented 8 years ago

this is backwards compatible right?

dongsupark commented 8 years ago

@jonboulle Yes I think so.

jonboulle commented 8 years ago

SGTM

On Thu, May 26, 2016 at 3:59 PM, Dongsu Park notifications@github.com wrote:

@jonboulle https://github.com/jonboulle Yes I think so.

— You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub https://github.com/coreos/fleet/pull/1596#issuecomment-221878647

kayrus commented 8 years ago

@dongsupark LGTM

dongsupark commented 8 years ago

Merged https://github.com/coreos/fleet/pull/1596. Thanks.