search

coreos / fleet

fleet ties together systemd and etcd into a distributed init system
Apache License 2.0
2.42k stars 302 forks source link

Removed visible credentials #1608

Closed ewoutp closed 8 years ago

ewoutp commented 8 years ago

Fixes https://github.com/coreos/fleet/issues/1607

dongsupark commented 8 years ago

In general it looks good. Ideally the subject line should be prefixed by a subsystem name, e.g. "docs: ", but in the case of documents, I'd suppose, that's not a strict rule. BTW Reading this document, I start to think that this is not the only place where AWS keys are exposed. But sometimes I have to admit, I can't fix everything. ;-) So if there's no objection, I'll merge it tomorrow.

dongsupark commented 8 years ago

Merged https://github.com/coreos/fleet/pull/1608. Thanks.