coreos / fleet

fleet ties together systemd and etcd into a distributed init system
Apache License 2.0
2.42k stars 303 forks source link

*: introduce an option UseLeaseTTL for lease manager's TTL #1692

Open dongsupark opened 7 years ago

dongsupark commented 7 years ago

Originally written by @hectorj2f Taken from https://github.com/giantswarm/fleet/tree/patch_lease_ttl

dongsupark commented 7 years ago

It turns out that this PR results in performance regressions. Nomi benchmark shows a large number of missing units, as well as a huge variation of unit start times. Its reason is that leaseTTL is not set to a big value any more in Engine.Run(), in case of enable_grpc==true. If the leaseTTL is set to a big value again, performance becomes normal again. Though in that case, there's no point in introducing the UseLeaseTTL option at all.

Until we could find out a solution, let's not merge.