Open dongsupark opened 7 years ago
It turns out that this PR results in performance regressions. Nomi benchmark shows a large number of missing units, as well as a huge variation of unit start times.
Its reason is that leaseTTL
is not set to a big value any more in Engine.Run()
, in case of enable_grpc==true
.
If the leaseTTL
is set to a big value again, performance becomes normal again. Though in that case, there's no point in introducing the UseLeaseTTL
option at all.
Until we could find out a solution, let's not merge.
Originally written by @hectorj2f Taken from https://github.com/giantswarm/fleet/tree/patch_lease_ttl