search

coreos / fleet

fleet ties together systemd and etcd into a distributed init system
Apache License 2.0
2.42k stars 302 forks source link

Drop legacy state management code #957

Open bcwaldon opened 10 years ago

bcwaldon commented 10 years ago

We've kept backwards-compatibility with the old state namespace since the change to the new namespace in v0.7.0. We can remove the old code once fleet v0.7.0+ makes it to the CoreOS stable channel.

bcwaldon commented 10 years ago

...and with v444.4.0 making it to stable, we can go ahead and do this.

bcwaldon commented 10 years ago

Not so fast. Need https://github.com/coreos/fleet/pull/991 to make it out to stable first to ensure the upgrade path is nice and clean.

bcwaldon commented 9 years ago

This is no longer blocked. v0.9.0 has made it to CoreOS Stable.

wuqixuan commented 9 years ago

@bcwaldon Seems the old code can be removed now.

jonboulle commented 9 years ago

@wuqixuan any chance you want to take a swing at this?

wuqixuan commented 9 years ago

@jonboulle , I am reviewing all the ISSUE and PR now one by one. There are so many ISSUE and PR pending, I hope can help the community to progress. : )

As for this PR, "statePrefix = "/state/"" is only used by legacyUnitStatePath, and the functions using legacyUnitStatePath always call unitStatePath or unitStatesNamespace. So the code of "statePrefix", "legacyUnitStatePath" can be removed. And the code currently is stable enough I think.