Fix: iptables stats tests for iptables >= 1.8.9

coreos / go-iptables

Go wrapper around iptables utility

Apache License 2.0

1.11k stars 257 forks source link

Fix: iptables stats tests for iptables >= 1.8.9 #113

Closed costasd closed 10 months ago

costasd commented 11 months ago

IPTables fixed a couple long-standing discrepancies in ipv4/ipv6's -L output. Unfortunately these fixes break out tests and potentially, stat parsing.

In detail, the following were fixed in 1.8.9 and later:

ip6tables' opt column outputting spaces instead of dashes
ip6tables' prot column not resolving "all" to "0", even with numeric mode activated.
iptables' prot column not resolving "all" to "0", even with numeric mode activated.

Handle them, so that tests keep working post 1.8.9.

costasd commented 10 months ago

@costasd Thanks for your change! It looks like the tests are failing - can you please take a look?

Ouch, sorry about that, missed the conditional for IPv4. Added, should work now. Thanks!