coreos / go-iptables

Go wrapper around iptables utility
Apache License 2.0
1.11k stars 257 forks source link

Added Replace method to replace rulespec (in specified pos) #87

Closed machooo-x closed 1 year ago

machooo-x commented 3 years ago

This change can support the modification of rules, and there is no conflict for the used items

squeed commented 2 years ago

Hmm, not sure why checks aren't running. Lemme take a look.

squeed commented 2 years ago

Let's try... closing and re-opening :-).

squeed commented 2 years ago

@machooo-x can you fix the tests, please?

machooo-x commented 1 year ago

@machooo-x can you fix the tests, please?

Dear reviewer, hello. I am very sorry for taking so long to resolve this testing issue. Now that I have made changes, could you please take a look and help me merge if possible? If there are any further issues, please let me know and I will definitely solve them. :)

machooo-x commented 1 year ago

Please fix the tests.

If the test still fails, can you help me solve it conveniently? I can only consider doing this now. Thank you very much.

squeed commented 1 year ago

I've re-triggered the tests - let's take a look :-).

machooo-x commented 1 year ago

I've re-triggered the tests - let's take a look :-).

I'm very sorry for the delay in your time due to my mistake. I have fixed the issue that was just tested, please trigger the test again. : )

machooo-x commented 1 year ago

Please fix the tests.

Dear reviewer, hello. If it's convenient, please trigger the workflow again and trigger the test. I need your help~~~ : )

travier commented 1 year ago

Can you rebase this PR on top of the latest changes in the repo? This will make it easier to review.

machooo-x commented 1 year ago

Member

I have added this change to the latest branch. If there are any further issues, please let me know. : )

machooo-x commented 1 year ago

Can you rebase this PR on top of the latest changes in the repo? This will make it easier to review.

Dear member, if you have time, could you take a look at my changes this time? I want to know if it was successful. If not, I will follow your advice until it is successful.

machooo-x commented 1 year ago

Dear squeed, will I appear on the list of contributors? @squeed If so, I would be very happy. : )

squeed commented 1 year ago

That should happen automatically, unless there's something else you're thinking of.