login1 command wrappers do not return the call error

coreos / go-systemd

Go bindings to systemd socket activation, journal, D-Bus, and unit files

Apache License 2.0

2.43k stars 308 forks source link

login1 command wrappers do not return the call error #326

Open coderanger opened 4 years ago

coderanger commented 4 years ago

The pattern used in other packages here is something like return c.object.Call(...).Err but the wrapper methods in login1 just swallow any errors.

lucab commented 4 years ago

Thanks for the report. I agree it would be better to align all those methods to return proper error value. If you are interested in doing it, I'll gladly review and merge a PR doing that.