search

coreos / go-tcmu

Go SCSI emulation via the Linux TCM in Userspace module
Apache License 2.0
53 stars 26 forks source link

return error when findDevice failed #3

Closed nak3 closed 8 years ago

jonboulle commented 8 years ago

This is already returning the error using a named result parameter: https://golang.org/doc/effective_go.html#named-results

jonboulle commented 8 years ago

Thanks for the patch, as explained above, this is not necessary, so I'm going to close it out. (There's an argument that we should omit the named return parameter entirely, for explicitness, but in that case it'll be a more invasive change, so please file a new PR).

nak3 commented 8 years ago

Thank you, you are right. That's my bad. Yes, in device.go, there is no consistency to use named result parameters.