coreos / ignition

First boot installer and configuration tool
https://coreos.github.io/ignition/
Apache License 2.0
840 stars 247 forks source link

dracut: add dependency network to ignition-mount.service #1940

Closed tormath1 closed 2 months ago

tormath1 commented 2 months ago

On some providers (like Equinix Metal), there is a network dependency for the umount stage, network must be still around when ExecStop is executed.

Thanks @dustymabe for the suggestion on the fix. :muscle:


Tested on Flatcar CI with Equinix Metal tests:

[ 22.605284] ignition[1212]: INFO : no configs at "/usr/lib/ignition/base.d" [ 22.629140] ignition[1212]: INFO : no config dir at "/usr/lib/ignition/base.platform.d/packet" Stopping systemd-resolved.service - Network Name Resolution...

[ 22.629185] ignition[1212]: INFO : umount: umount passed [ OK ] Stopped systemd-udev-trigger.service - Coldplug All udev Devices.

[ 32.565905] ignition[1212]: INFO : GET error: Get "https://metadata.packet.net/metadata": net/http: timeout awaiting response headers [ 32.766388] ignition[1212]: INFO : GET https://metadata.packet.net/metadata: attempt #2 [ * ] Job ignition-mount.service/stop running (11s / 1min 30s)

M [ * ] Job ignition-mount.service/stop running (11s / 1min 30s)

dustymabe commented 2 months ago

this LGTM - @jlebon @prestist - WDYT?